[darcs-devel] Re: darcs patch: Don't use hardcoded stdout fd number and check return ...

Aaron Denney wnoise at ofb.net
Mon Jan 24 16:01:09 PST 2005


On 2005-01-24, Jan-Benedict Glaw <jbglaw at lug-owl.de> wrote:
> --=_
> Content-Type: text/plain
> Content-Transfer-Encoding: quoted-printable
>
> Mon Jan 24 21:38:26 CET 2005  Jan-Benedict Glaw <jbglaw at lug-owld.e>
>   * Don't use hardcoded stdout fd number and check return value

Checking the return value is good, but why not hard-code the
STDOUT_FILENO?  It can't change, and everybody knows what "1" means,
and it's shorter.

-- 
Aaron Denney
-><-





More information about the darcs-devel mailing list