[darcs-devel] Optimizing "darcs diff"

David Roundy droundy at abridgegame.org
Sun Mar 6 05:54:26 PST 2005


On Sat, Mar 05, 2005 at 10:55:02PM -0800, Kannan Goundan wrote:
> 
> --- David Roundy <droundy at abridgegame.org> wrote:
> > Here we could make things a bit easier to read I think with a case
> > statement:
> > 
> >   case prune_list new_tf contents of
> >     [] -> Nothing
> >     pruned_contents -> Just (SlurpDir name io pruned_contents)
> 
> Yeah, this is nicer.  I gotta get into the habit of using pattern
> matching more often.
>
> I can send you a new version of the prune patches, if you'd like. 
> But if it's just easier to make those fixes yourself, go ahead.

That would be nice.  I've got plenty of other stuff to work on...

> > Do keep in mind that it'll still be slow if you run it with no
> > arguments... we could work around that by internally running a
> > whatsnew before doing the actual diff, though...
> 
> Since I'm already here, I guess I'll see if we can easily get a
> TreeFilter out of the "whatsnew" logic.

Sounds good! :)
-- 
David Roundy
http://www.darcs.net




More information about the darcs-devel mailing list