[darcs-devel] darcs patch: add make_changelog, a tool to auto-gener... (and 10 more)

[Tomasz Zielonka]

On Thu, May 12, 2005 at 05:48:59AM -0400, David Roundy wrote:
> On Thu, May 12, 2005 at 09:45:00AM +0200, Tomasz Zielonka wrote:
> > On Thu, May 12, 2005 at 02:44:00AM +0100, Ian Lynagh wrote:
> > > Also, couldn't this give the wrong answer if patches are reordered?
> > > Probably not a problem for the darcs-stable repo itself, I guess.
> > 
> > Yes, we discussed this with David and decided that it's not an issue for
> > stable. Hmmm... but yes, we can get some strange results in
> > darcs-unstable. Thinking about a solution... perhaps I should simply
> > check what patches are included in each tag?
> 
> Yeah, that would sound simplest.  For some reason I had been thinking
> commutation would be necesary, but of course it won't be.  But I'd still
> lean towards just getting it working for stable, and then later extending
> it to work with out-of-order patches.

OK, I've just sent a new set of patches, which doesn't yet solve this
issue. I'll work on it later.

> > > > +matchTag_1_0_2 :: Matcher
> > > > +matchTag_1_0_2 = match_pattern (PatternMatch "exact \"TAG 1.0.2\"")
> > > 
> > > Shouldn't this ("1.0.2") be an argument to the program, and the function
> > > renamed accordingly?
> > 
> > Yes, I thought about it.
> 
> But this really *is* meant to be hard coded right? The point is that this
> is a backwards-compatibility fix to handle changelog entries that aren't in
> the new format.

Well, yes.

Best regards
Tomasz