[darcs-devel] Bug in apply patch bundle parsing. (triggered by dist
tarball email)
David Roundy
droundy at abridgegame.org
Mon Nov 7 05:35:31 PST 2005
Content-Description: A darcs patch for your repository!
>
> New patches:
>
> [Avoid putting a wrongly-named directory in dist tarball if the name we wanted already exists in $TMPDIR
> Simon McVittie <http://www.pseudorandom.co.uk/>**20051106145821] {
This patch has an interesting feature, which is that it exposes a bug in
apply. I think because it's got two levels of MIME hierarchy, darcs
doesn't do the MIME decoding right, which would be okay, except that
because this patch has only one patch in its context, the MIME "=2D" after
that first patch in the context causes darcs to conclude that it has
reached the end of the patch (since it doesn't understand it), and stop
before reading the patch hash. It therefore treats this as a legacy patch,
from before the hash was included in sent patches, and fails to check to
see if it can read the patch properly. :(
I think there are two bugs here. One is that we don't demime the message
properly (which is a real bug, but shouldn't be a corruption-causing bug).
The second is that we give up too soon in looking for a patch hash.
Perhaps we should remove the legacy support, or require a flag in order to
accept hashless patch bundles. Ideas?
--
David Roundy
http://www.darcs.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20051107/5d5c48a9/attachment.pgp
More information about the darcs-devel
mailing list