[darcs-devel] [darcs #549] darcs bug
Jan Rychter via RT
bugs at darcs.net
Tue Oct 11 05:27:44 PDT 2005
Tue Oct 11 08:27:31 2005: New ticket: 549.
Transaction: Ticket created by jan at rychter.com
Queue: Darcs
Subject: darcs bug
Owner: Nobody
Requestors: jan at rychter.com
Status: new
Ticket <URL: http://bugs.darcs.net/.//Ticket/Display.html?id=549 >
Dear Darcs Team,
I have encountered the following problem:
[9:55] tnuctip:/home/jwr/lisp/ucw/ucw_dev>darcs pull
Pulling from "http://common-lisp.net/project/ucw/repos/ucw_dev"...
Sun Sep 25 18:41:21 CEST 2005 Marco Baringer <mb at bese.it>
* Fix silly and stupid bug in parse-form-data-encoded (we were forgetting that dolist always returns NIL)
Shall I pull this patch? (1/3) [ynWvpxqadjk], or ? for help: y
Sun Sep 25 18:42:27 CEST 2005 Marco Baringer <mb at bese.it>
* Move the stylesheet and the www-roots for the various apps.
Shall I pull this patch? (2/3) [ynWvpxqadjk], or ? for help: n
Tue Sep 27 21:34:46 CEST 2005 Marco Baringer <mb at bese.it>
* Removed unused junk in the upload form example
Shall I pull this patch? (3/3) [ynWvpxqadjk], or ? for help: n
darcs: bug in darcs!
in function reconcile_unwindings
Original patch:
merger 0.0 (
regrem 0.0 (
hunk ./src/backend/httpd.lisp 501
- headers body)
+ (cdr it) headers body)
hunk ./src/backend/httpd.lisp 501
- headers body)
+ (cdr it) headers body)
)
merger 0.0 (
merger 0.0 (
hunk ./src/backend/httpd.lisp 501
- headers body)
+ (cdr it) headers body)
hunk ./src/backend/httpd.lisp 501
- headers body)
+ (cdr it) headers body)
)
hunk ./src/backend/httpd.lisp 477
- (with*
- (let* ((boundary=-start (search "boundary=" content-type))
- (boundary (subseq content-type
- (+ boundary=-start #.(length "boundary="))))
- (mime-entites (rfc2388:parse-mime body boundary :write-content-to-file nil))
- (params '()))
- (ucw.backend.dribble "Processing mime entities ~S" mime-entites))
- (dolist* ((body headers) mime-entites))
- (dolist* ((header-name value secondary-values) headers))
- (when (and (string-equal "Content-Disposition" header-name)
- (string-equal "form-data" value)))
- (progn
- (aif (assoc "name" secondary-values :test #'string=)
- (push (cons (cdr it)
- (if (= 1 (length secondary-values))
- (progn
- (ucw.backend.dribble "Got regular parameter ~S from form data with value ~S"
- (cdr it) body)
- ;; there are no headers for this mime
- ;; part other than the name, just use
- ;; the body.
- body)
- (progn
- (ucw.backend.dribble "Get mime parameter ~S from form data. Headers: ~S; Body: ~S"
- (cdr it) headers body)
- ;; a mime-part object with other headers.
- (make-mime-part :headers headers :body body))))
- params)
- (warn "Ignoring unnamed parameter with body ~S." body))
- params)))
+ (let* ((boundary=-start (search "boundary=" content-type))
+ (boundary (subseq content-type
+ (+ boundary=-start #.(length "boundary="))))
+ (mime-entites (rfc2388:parse-mime body boundary :write-content-to-file nil))
+ (params '()))
+ (ucw.backend.dribble "Processing mime entities ~S" mime-entites)
+ (dolist* ((body headers) mime-entites)
+ (dolist* ((header-name value secondary-values) headers)
+ (when (and (string-equal "Content-Disposition" header-name)
+ (string-equal "form-data" value))
+ (aif (assoc "name" secondary-values :test #'string=)
+ (push (cons (cdr it)
+ (if (= 1 (length secondary-values))
+ (progn
+ (ucw.backend.dribble "Got regular parameter ~S from form data with value ~S"
+ (cdr it) body)
+ ;; there are no headers for this mime
+ ;; part other than the name, just use
+ ;; the body.
+ body)
+ (progn
+ (ucw.backend.dribble "Got mime parameter ~S from form data. Headers: ~S; Body: ~S"
+ (cdr it) headers body)
+ ;; a mime-part object with other headers.
+ (make-mime-part :headers headers :body body))))
+ params)
+ (warn "Ignoring unnamed parameter with body ~S." body)))))
+ params))
)
)
Please report this to bugs at darcs.net
If possible include the output of 'darcs --exact-version'.
[9:55] tnuctip:/home/jwr/lisp/ucw/ucw_dev>
[9:55] tnuctip:/home/jwr/lisp/ucw/ucw_dev>darcs --exact-version
darcs compiled on Jul 28 2005, at 23:51:37
# configured Tue May 24 18:34:35 EDT 2005
sh ./configure
Context:
[TAG 1.0.3
Tomasz Zielonka <tomasz.zielonka at gmail.com>**20050524215127]
[9:56] tnuctip:/home/jwr/lisp/ucw/ucw_dev>
I am reporting it as instructed by darcs...
thanks,
--J.
More information about the darcs-devel
mailing list