[darcs-devel] darcs patch: Added the ability to add long comments to tags. By de...

[Tom Counsell]

Hello David

On 13 Sep 2005, at 13:15, David Roundy wrote:
>  I'd really prefer it to be implemented
> somewhat differently (see below).

I didn't expect I'd get it right on first try, so thank you for the  
feedback!

>> +\begin{code}
>> +get_log :: [DarcsFlag] -> String  -> IO (String, [String])
>> +get_log opts oldname = gl opts
>>
> [...]
>
> I really dislike like the fact that we're duplicating this code.   
> It should
> be pretty straightforward (although it means learning a bit more  
> Haskell)
> to add get_log to the export list of Record.lhs, and then add to  
> Tag.lhs an
> import statement "import Record ( get_log )".  Then you won't need to
> import nearly as much to Tag.  I'm working under the assumption  
> here that
> you haven't had to modify get_log... if that's not the case, then  
> I'd like
> to hear what you needed to do to it.

I needed to modify it to:
1) Default to not prompting the user
2) Eliminate the reference to chs (patches?)

I don't know whether it would be possible to distil this into a  
common method (if method is the right term in Haskell?).  I'll get my  
thinking cap on.

Anyway, I'll see what I can do for an improved version (with test).

Thanks

Tom