[darcs-devel] [issue163] careful_atomic_create breaks when people are stupid

[Juliusz Chroboczek]

New submission from Juliusz Chroboczek <jch at pps.jussieu.fr>:

Careful_atomic_create in atomic_create.c first creates a temporary
lock file that depends on the hostname.  It then attempts to hard link
it to the actual lock file.

If the filesystem doesn't support hard links (e.g. we're using FAT),
careful_atomic_create falls back to the sloppy strategy.

Interestingly, some people choose to have colons in the hostname of
their machine (which violates RFC 952 and has interesting side-effects
when using X).  In that case, creation of the temporary filename
fails, which causes grief and suffering.

The obvious fix is to shoot people who put colons in hostnames.

The other obvious fix is to replace all weird characters with dashes
in careful_atomic_create.

                                        Juliusz

----------
messages: 623
nosy: droundy, jch, tommy
status: unread
title: careful_atomic_create breaks when people are stupid

____________________________________
Darcs issue tracker <bugs at darcs.net>
<http://bugs.darcs.net/issue163>
____________________________________