[darcs-devel] darcs patch: make directory_confusion pass with hashe... (and 10 more)

[David Roundy]

Hi Eric (and others),

One last patch for the weekend:  eliminating DarcsRepo.am_in_repo
entirely.  As the comment below says, this is definitely a Good Thing.  It
means that darcs commands that operate on repositories always use the same
definition of what a repository is, which gives better predictability as to
what one is doing.  This patch sequence is worth reviewing, but I'm pretty
confident in it, so you've got my vote for applying it.

I've still got the checkpoint question to address, and probably more bugs
to track down, but am close to the point where I'll hope people will start
playing with hashed inventories to see how they behave.  Which means that
it'd be worth the effort of interested persons to see if they want to
suggest changes to the actual format of the hashed inventories.  It might
be nice to add subdirectories, either by date or by the first couple
characters of the hash itself.  And I'm open to suggestions to make the
format more parseable by third party tools.  I just hacked this one
together in... well quite a short period of time, and since then have been
focusing on the rest of the code (which really doesn't depend on the
inventory format in any interesting way).

David

Sat Dec  2 19:55:51 PST 2006  David Roundy <droundy at darcs.net>
  * make directory_confusion pass with hashed inventories.
  I'm not sure whether there is still a bug in the pending handling here, but
  at least it doesn't crash...

Sat Dec  2 21:50:19 PST 2006  David Roundy <droundy at darcs.net>
  * Make get_tag test work with hashed inventories.

Sat Dec  2 21:54:52 PST 2006  David Roundy <droundy at darcs.net>
  * make replace work with hashed inventories.

Sat Dec  2 22:43:55 PST 2006  David Roundy <droundy at darcs.net>
  * fix more incompatible uses of DarcsRepo.

Sun Dec  3 09:32:07 PST 2006  David Roundy <droundy at darcs.net>
  * add some more hashed_inventory.sh tests.

Sun Dec  3 09:37:22 PST 2006  David Roundy <droundy at darcs.net>
  * fix new get to not mess up pending (fixes latest hashed_inventory.sh tests).

Sun Dec  3 12:58:26 PST 2006  David Roundy <droundy at darcs.net>
  * make it an error to "put" into a preexisting directory.
  This changes darcs' behavior I believe for the better.  Often one could be
  tempted to try to put into a directory, expecting to have the repository
  created as a subdirectory there, and it seems confusing (confused me) to
  have instead the repository contents mingled with whatever was already in
  that directory.  Put should behave like get in this regard, in that it
  shouldn't mix the new repo with a preexisting directory.

Sun Dec  3 13:11:41 PST 2006  David Roundy <droundy at darcs.net>
  * make put work with hashed inventories (and test for this).

Sun Dec  3 14:08:33 PST 2006  David Roundy <droundy at darcs.net>
  * make get and put reuse initialize code.
  This patch actually fixes put to properly accept and use any flags that
  init accepts, which is a Good Thing.  It also ensures that get behaves
  consistently with init in the future.  Also a Good Thing.

Sun Dec  3 18:08:23 PST 2006  David Roundy <droundy at darcs.net>
  * fix hashed inventory bug in add and prevent it happening again.

Mon Dec  4 07:31:28 PST 2006  David Roundy <droundy at darcs.net>
  * eliminate DarcsRepo.am_in_repo.
  This patch is a Good Thing, even though repair and optimize don't yet
  properly support anything bug old-fashioned repositories, because without
  it, when using such repositories, one can find those command operating on a
  different repository than intended (e.g. the test suite runs optimize on
  the darcs repository itself).  Now they'll fail as they ought to, when run
  on a repo format they don't support.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-darcs-patch
Size: 93767 bytes
Desc: A darcs patch for your repository!
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20061204/a3511e17/attachment.bin