[darcs-devel] Re: darcs patch: Windows hard link support

Simon Marlow simonmar at microsoft.com
Mon Dec 11 08:51:01 PST 2006


Juliusz Chroboczek wrote:
>>+#define _WIN32_WINNT 0x0500
>>+#include <windows.h>
>>hunk ./maybe_relink.c 39
>>-    return 0;
>>+    BOOL result;
>>+    result = CreateHardLink(src, dst, NULL);
>>+    if (!result)
>>+        return 0;
>>+    else
>>+        return -2;
>>}
> 
> 
> I don't understand Windows -- but that looks completely bogus to me.
> Does it obey the description in the comment just below?

Er.  Ok, I completely failed to understand what maybe_relink() was supposed to 
do, and didn't notice that it should compare the files before attempting to 
link.  Sorry about that, please ignore the patch, maybe I'll submit a fixed one 
at some point.

Cheers,
	Simon





More information about the darcs-devel mailing list