[darcs-devel] darcs patch: fix [issue370], darcs ignored args contained in VISUAL...

Eric Y. Kow eric.kow at gmail.com
Mon Dec 25 05:20:22 PST 2006


> Wed Dec 20 12:08:07 CET 2006  Benedikt Schmidt <beschmi at cloaked.de>
>   * fix [issue370], darcs ignored args contained in VISUAL variable
>   given VISUAL="emacs -nw", darcs would run "emacs file" instead of
>   "emacs -nw file"

This makes me hesitate somewhat.  Can we discuss it a little bit?
It's probably ok; I just want to see what other people think.
 
- This patch will break things for people whose VISUAL has a space in it
  something like "/c/Program Files/FooEditor"

  Then again, I don't know if you're even supposed to be able to set
  stuff like this.  It seems unlikely that people will do such a
  thing, and that setting such a path is asking for trouble
  anyway.
  
  The thing that would make me lean towards accepting this is that just
  breaking up on words is an easy way to get those variables.
  
  Do we really want to bother implementing an escaping mechanism for
  this?  It'll only be a tiny bit of Parsec or whatever, but knowing
  what the right behaviour should be, and making sure we follow it might
  be tricky.  Anyway, how do other Unix-y programs handle the VISUAL or
  EDITOR environment variables?  Whatever we do should be compatible
  with that.

- You probably worked this out too, but the reason emacs gets called
  is not because the arguments are being discarded, but because darcs
  attempts to execute the non-existent command "emacs -nw", fails,
  and falls through to the default emacs.  To test this claim, you
  can try some other editor with a switch; you'd also get emacs.
  
  Not so much for your benefit, but anybody following this thread.
 
- It might be worth using something like CommandLine.parseCmd just to
  have things in one place.  parseCmd is overkill, but we could just
  pass it an empty table.

-- 
Eric Kow                     http://www.loria.fr/~kow
PGP Key ID: 08AC04F9         Merci de corriger mon français.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 186 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20061225/d0445516/attachment.pgp


More information about the darcs-devel mailing list