[darcs-devel] darcs patch: Coalesce setpref (issue70 and RT #349)

David Roundy droundy at darcs.net
Sat Jan 7 04:43:58 PST 2006


On Fri, Jan 06, 2006 at 06:34:15PM +0100, Juliusz Chroboczek wrote:
> > hunk ./PatchCommute.lhs 1018
> > +coalesce (ChangePref p f1 t1, ChangePref p2 f2 t2) | p == p2 && t2 == f1 = Just $ ChangePref p f2 t1
> 
> Hmm...  I'm not sure this doesn't break some of Darcs' determinism
> properties.  David, is this okay?

Yeah it's okay.  Coalesce is only used on local (unrecorded) changes, and
this is precisely the sort of behavior it's supposed to have.
-- 
David Roundy
http://www.darcs.net




More information about the darcs-devel mailing list