[darcs-devel] darcs patch: use FastPackeString when examining execu... (and 5 more)

[ptp at lysator.liu.se]

This is a change I said I'd do nine months ago. It is a new
policy test meant to catch code that we know can cause trouble.
Quoting from some mails:

  Will
    I believe this is caused by darcs trying to delete the temp file
    used for SFTP output, while it is still open. IIRC this has been
    a problem in various places because deleting an open file works
    everywhere but on Windows. [...] I've sent in a patch that uses
    readFilePS instead of readFile, which seems to ensure that the
    file is closed before it is deleted.
  
  David
    Indeed, in my head at least, we have a policy that we shouldn't
    use readFile (or hGetContents), and I'm not sure how it sneaked
    in here. I wonder if it would be worth adding some sort of test
    to the test suite that checks for readFile uses?

I also moved the test for tabs from the GNUmakefile to this new
policy test.



Sat Jul 29 15:06:45 CEST 2006  Tommy Pettersson <ptp at lysator.liu.se>
  * use FastPackeString when examining executable scripts in Get

Sun Jul 30 14:10:48 CEST 2006  Tommy Pettersson <ptp at lysator.liu.se>
  * rename test 0_test to better name harness

Sun Jul 30 14:11:58 CEST 2006  Tommy Pettersson <ptp at lysator.liu.se>
  * ratify some uses of readFile and hGetContents

Sun Jul 30 14:14:04 CEST 2006  Tommy Pettersson <ptp at lysator.liu.se>
  * add test for haskell policy

Sun Jul 30 14:23:48 CEST 2006  Tommy Pettersson <ptp at lysator.liu.se>
  * move test for tabs from makefile to haskell_policy test

Sun Jul 30 14:25:05 CEST 2006  Tommy Pettersson <ptp at lysator.liu.se>
  * remove some tabs from haskell source

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-darcs-patch
Size: 69641 bytes
Desc: A darcs patch for your repository!
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20060730/6d8eac83/attachment.bin