[darcs-devel] darcs patch: add test that unrecord of tag removes ch... (and 2 more)

[ptp at lysator.liu.se]

Here is the complete fix for Issue281, with a patch that merges
it all with darcs-unstable.


In some e-mail I can't find, Eric Kow wrote:
> Some questions/comments:
>  1. How come remove_from_checkpoint_inventory takes a repodir and
>     write_checkpoint_patch does not?

I tried to find a pattern to which functions take a dir
argument, and which do not but rely on cwd, but failed. So I
changed remove_from_checkpoint_inventory to rely on cwd.

>  2. What if repodir is "" -- can that ever happen? perhaps (///) is a
>     better choice than (++)

I agree (///) is better, but not needed any more due to 1.

>  3. (minor and silly) Maybe mapMaybe is better than catMaybes . map

Much better, thanks!

>  4. I notice that we're creating the checkpoint directory if it's
>     missing.  Is this so that read_checkpoints doesn't blow up?
>     Shouldn't this be read_checkpoints' job, then?

Hm, no. read_<whatever> wouldn't blow up, but probably return
Nothing, since that's what's there. Write_<whatever> would
however blow up with some dir doesn't exist exception, since we
need that place to write in.


Sat Oct  7 17:26:48 CEST 2006  Tommy Pettersson <ptp at lysator.liu.se>
  * add test that unrecord of tag removes checkpoint

Tue Oct 31 23:01:57 CET 2006  Tommy Pettersson <ptp at lysator.liu.se>
  * remove unrecorded tags from the checkpoint inventory (issue281)
  The commands Check, Get and Repair all can make use of the checkpoint
  inventory. Unrecord, Unpull and Obliterate forgot to remove deleted patches
  from that inventory.

Thu Nov  2 19:48:34 CET 2006  Tommy Pettersson <ptp at lysator.liu.se>
  * resolve conflicts
  Merge Unrecord fix for checkpoints inventory with Repository code refactoring.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-darcs-patch
Size: 22416 bytes
Desc: A darcs patch for your repository!
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20061102/5f67eca4/attachment.bin