[darcs-devel] [issue332] Feature request: ask to record if tests fail

[Josh Hoyt]

New submission from Josh Hoyt <josh at janrain.com>:

Sometimes unit tests fail for reasons that are beyond the code that is
being tested. For instance, at work, we test code that uses a SQL
database. If the testing database server is down or misconfigured, the
tests fail even if the code is correct. Also, sometimes the tests fail
in a way that the solution is obvious.

In either of these cases, it can be frustrating to have to select
which changes to record and re-enter the patch name and comment. I
would like to be able to decide after the tests have failed whether or
not to record the patch. That way I can unrecord if it turns out the
patch is fundamentally flawed, or I can amend-record if the fix is
obvious.

Looks like you have a bad patch: My slightly flawed patch
Shall I record it anyway? [yN]

I think this is a happy medium between --no-test and flat-out
rejecting patches that don't pass the tests. I would be happy with
this behaviour being available through an option
(--ask-record-failed?) or on by default. I'm also willing to try to
implement it, if that helps.

Josh

----------
messages: 1178
nosy: EricKow, droundy, josh, tommy
status: unread
title: Feature request: ask to record if tests fail

____________________________________
Darcs issue tracker <bugs at darcs.net>
<http://bugs.darcs.net/issue332>
____________________________________