[darcs-devel] darcs patch: fix for Issue111, obliterate --all

[David Roundy]

On Thu, Nov 30, 2006 at 02:29:45PM +0100, Tommy Pettersson wrote:
> On Wed, Nov 29, 2006 at 08:42:50AM -0800, David Roundy wrote:
> > Here's a patch for Issue111.  Feel free to debate among
> > yourselves whether it's actually a Good Thing, but it's
> > an easy change.  And as you might guess, my leaning is for
> > it to go in.
> 
> I think it's a good change, but... it have some potential
> dangers. One test failed with this patch because it did
> "echo ALL all > _darcs/prefs/defaults". I've sent a patch
> to make the test use --interactive. Are there any darcs users
> out there with "ALL all" in their defaults files??

Hmmm.  Yes, that is potentially confusing--and dangerous.  One might almost
want to ignore the defaults file for this flag and this command.  But on
the other hand, putting ALL --all in one's defaults file also seems pretty
reckless.  So I think a release note warning that "ALL --all" is now a very
dangerous default is probably sufficient.
-- 
David Roundy
Department of Physics
Oregon State University