[darcs-devel] patches accepted 2006-10-29

Eric Y. Kow eric.kow at gmail.com
Sun Oct 29 22:59:33 PST 2006


On Sun, Oct 29, 2006 at 17:35:35 -0800, Wim Lewis wrote:
> >  * Allow escaped quotes in `quoted'.
> 
> This breaks make_changelog (and therefore "make" which invokes "make  
> ChangeLog") for me:

Thanks, Wim.  I have pushed a patch to undo the change.

I have also thought it through deeper.  Whereas my first reaction was
"sure, I don't see why not", my new thinking is that we should avoid
this feature because

1. it adds confusion between escaping for darcs and escaping for
   regexps
2. it introduces an inconsistency between quoted and unquoted mode

KISS, in other words.  So, sorry Dave but thanks anyway.  On the other
hand, if anybody disagrees with this and really wants to see escaped
quotes in matchers, please speak up.

(Sigh... Eric needs to learn to run make and not just make test)

-- 
Eric Kow                     http://www.loria.fr/~kow
PGP Key ID: 08AC04F9         Merci de corriger mon français.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 186 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20061030/ba889fb3/attachment.pgp


More information about the darcs-devel mailing list