[darcs-devel] darcs patch: Do not redirect to or from /dev/null when calling ssh.

[Eric Kow]

Part 2 of my patch resubmission.

Note that this modified from my last "Do not redirect" patch.  It
incorporates changes from read sftp batch file in from stdin (part of
issue237).

Note that this semantically depends on part 1 of this resubmission.  It
is probably ok to apply the other patch without this one.  It is not a
good idea to apply this one without the other.  I am sending it this way
mostly because I am tired/confused and fear I have done something
stupid.  

Whilst testing, I noticed that although this works fine with OpenSSH,
it does not work with putty (on my Mac -- yes, putty is available for
Unix).  Then again, putty-on-unix does not seem to work with darcs 1.0.8
either.  In both cases, the symptom is that darcs tells us it could not
fetch a file.  Now with this patch, in addition to it not working, you
also get repeated password prompts, but just the prompts, not the
ability to type them in.

Putty seems to be working just fine on Windows under 1.0.8 -- at least
nobody seems to be complaining about stuff other than the spurious
cm-related messages.  If Putty continues to work fine under Windows with
this patch,  I'll guess it's a keeper, because, seriously, who actually
uses putty under unix?  (famous-last-words moment?).

Could a Windows user give this a try?  Please do a get, pull and push.
Note: to isolate the problem, please make sure the server you connect
to is one that your putty already knows about.  There is a different
issue re: first-time connections that this patch does not aim to
address.

--------

Sun Sep  3 23:48:31 CEST 2006  Eric Kow <eric.kow at loria.fr>
  * Do not redirect to or from /dev/null when calling ssh.
  
  Redirection of stdin and stdout breaks putty, which uses these to
  interact with the user.  Quiet mode, and redirecting stderr are good
  enough for making ssh silent.
  

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-darcs-patch
Size: 4180 bytes
Desc: A darcs patch for your repository!
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20060904/9ef1ab58/attachment.bin