[darcs-devel] darcs patch: Fix Windows stderr non-redirection. (and 1 more)

[Eric Y. Kow]

On Sat, Sep 09, 2006 at 22:10:14 +0200, Tommy Pettersson wrote:
> Anyway, I had some difficulty reading the code (most of the code
> in Exec.lhs), so I tried to make it more readable, which (for me
> at least) means more simple.  So I only kept one version of exec (the
> fancy one, but with the name exec), and used the redirection data type
> all the way. This is merely a suggestion, for now -- "easy to read" is
> very subjective.

I think this is an improvement.  Thanks!

> I have changed the
> Windows code too, but have not tried to compile it since I don't
> have Windows.

I have a trick for that.  I just set #define WIN32 (after recording
the patch so I can easily revert it)

Alright, so this patch is waiting for two things

1) Eric - find Juliusz's message re: stderr redirection
    (I assume it's not the message where he accepted my patch)
    I would be happy for stderr to NOT be redirected by
    default, but just want to double-check the arguments,
    just to be conservative and avoid changing behaviour
    unless necessary.

2) A windows user - confirmation or denial
    Windows automatically redirects stderr when stdout is redirected,
    unless stderr is explicitly redirected somewhere.
    (That sounds like a silly behaviour!)

This patch goes in Saturday, pending #1 and reconsideration.

-- 
Eric Kow                     http://www.loria.fr/~kow
PGP Key ID: 08AC04F9         Merci de corriger mon français.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 186 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20060910/c8513e96/attachment.pgp