[darcs-devel] darcs patch: clean up unrevert and pending handling. (and 5 more)

[Eric Y. Kow]

On Thu, Sep 28, 2006 at 10:56:34 -0700, David Roundy wrote:
> Mon Sep 18 10:39:04 PDT 2006  David Roundy <droundy at darcs.net>
>   * add a bit of hashed inventory code.

Is writeHashFile in HashedRepo.lhs correct?  Shouldn't you be
tacking more stuff on that renameFile?

The patch looks alright otherwise (I was going to apply it on the
grounds of trusting David, and nothing jumping out at me), but one of
your later patches causes your hashed_inventory test to fail.
 
> Tue Sep 26 19:01:27 PDT 2006  David Roundy <droundy at darcs.net>
>   * add test target for testing hashed inventories.
> 
> Tue Sep 26 19:12:02 PDT 2006  David Roundy <droundy at darcs.net>
>   * put Repository in Show class for debugging ease.
>
> Tue Sep 26 19:45:14 PDT 2006  David Roundy <droundy at darcs.net>
>   * make darcs check use Repository framework.

Everything seems fine up to here...

> Tue Sep 26 19:45:05 PDT 2006  David Roundy <droundy at darcs.net>
>   * fix parsing of hashed inventories.

This patch causes a test to fail.  Luckily, it's only the test you just
created (good thing you created it!):

Running hashed_inventory.sh ...                  FAILED!

[snip]

$DARCS get temp1 temp2
Copying patch 1 of 1...darcs: /Users/kowey/darcsImpl/more-unstable/tests/temp1/_darcs/patches/20060930220209-ab4d8-57b3a1fcebda72d31fc3b9a9baa6d9f1bb86d705.gz: openBinaryFile: does not exist (No such file or directory)

TESTS FAILED!

Note:

ls _darcs/patches shows:
  ba87e204b389c1abac1f7e38fde8c88d6c4de350 
pending.tentative_prepend
pending

Not applying these patches.

Cheers,

-- 
Eric Kow                     http://www.loria.fr/~kow
PGP Key ID: 08AC04F9         Merci de corriger mon français.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 186 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20061001/e684b11e/attachment.pgp