[darcs-devel] darcs patch: Add tests specifically for applying patc... (and 3 more)

[Eric Y. Kow]

On Sat, Apr 21, 2007 at 15:47:26 -0700, David Roundy wrote:
> Here's the next take on the stuff for Issue434.
 
For what it's worth, this is going into unstable.

> - -      let pre_changed_files = apply_to_filepaths True (invert changes) files in
> +      let pre_changed_files = apply_to_filepaths (invert changes) files in

Shouldn't this be (runTolerantly $ apply_to_filepaths (invert changes) files)?

>  instance WriteableDirectory TolerantIO where
>       mWithCurrentDirectory = mInCurrentDirectory

> +instance WriteableDirectory SilentIO where
> +     mWithCurrentDirectory = mInCurrentDirectory

The duplication might not be so bad.  The reason is that some things you
might not actually want to be silent.  For example, if you remove a
directory and do not suceed, no big deal; however, you add a file and
fail, maybe you really do want to know about that, quiet or no.

-- 
Eric Kow                     http://www.loria.fr/~kow
PGP Key ID: 08AC04F9         Merci de corriger mon français.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 186 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20070422/f10e8b7c/attachment.pgp