[darcs-devel] darcs patch: fix ordering mistyping in sift_for_pending. (and 2 more)

David Roundy droundy at darcs.net
Wed Aug 8 01:08:01 UTC 2007


Hi Eric,

Here's a fix for the trouble we've had with optimize --reorder when
executed on the latest darcs unstable repository.  I'm not convinced
that it's the best solution, and it's definitely not a pretty solution,
but it is *a* solution.  If we optimize optimize a bit more, this
change won't be necesary, but I'd like to have it in there.  Basically,
I just added a pass over the patch sequence looking for patches and
their inverses, which show up when we apply both a patch and its inverse
to the repository (as happens in optimize).

David

Mon Aug  6 16:11:24 PDT 2007  David Roundy <droundy at darcs.net>
  * fix ordering mistyping in sift_for_pending.
  This doesn't change any behavior, but makes type correspond
  to actual order of patches in the list.

Tue Aug  7 17:48:26 PDT 2007  David Roundy <droundy at darcs.net>
  * add allFL function to Ordered.

Tue Aug  7 17:52:51 PDT 2007  David Roundy <droundy at darcs.net>
  * fix bug that revealed itself in optimize --reorder on unstable repo.
  I'm sure this fix doesn't make things worse, but am not convinced that it
  is a totally correct fix.  "Sifting for pending" is a subtle business,
  and in many ways this patch just works around this complexity.  On the other
  hand, I can't see another way to deal with this.  :(

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-darcs-patch
Size: 77059 bytes
Desc: A darcs patch for your repository!
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20070807/6ddc7798/attachment-0001.bin


More information about the darcs-devel mailing list