[darcs-devel] darcs patch: FastPackedString.hs: FastPackedString.hs: redefine lin...

[Gwern Branwen]

On 2008.04.15 07:29:54 -0700, David Roundy <droundy at darcs.net> scribbled 0.9K characters:
> On Mon, Apr 14, 2008 at 11:09:15AM -0400, gwern0 at gmail.com wrote:
> > Mon Apr 14 11:08:39 EDT 2008  gwern0 at gmail.com
> >   * FastPackedString.hs: FastPackedString.hs: redefine linePS/unlinesPS
> >   Turns out that my definitions were wrong - they differed and added a
> > newline where the old FPS versions didn't. So I've rewritten the wrapper
> > versions around ByteString, and checked them against the old ones with
> > QuickCheck. With these fixes, a bytestring darcs seems to pass all the
> > tests as a fps darcs.
>
> Applied, thanks!

Welcome.

> I'd rather have quickcheck tests added to the unit test program, by the
> way, than added in a commented manner.  But that's not a big deal, as the
> unit test requires quickcheck 2.0, which most developers probably don't
> have installed (and it's a pain to have installed, as it means you can't
> use quickcheck 1 any more, and quickcheck 2 isn't backwards-compatible).
> --
> David Roundy

Just as well, as I don't have QuickCheck 2 installed! I'm not entirely sure how useful they'd be in unit anyway, since it seems QuickCheck doesn't provide arbitrary instances for Char, much less ByteString?

--
gwern
nitrite CipherTAC-2000 SEAL TEXTA Marx York Gazprom Chobetsu of 007
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.osuosl.org/pipermail/darcs-devel/attachments/20080416/5855909a/attachment.pgp