[darcs-devel] darcs patch: copy over updated "shell_harness" to bugs.

David Roundy droundy at darcs.net
Thu Feb 14 15:02:06 UTC 2008


On Wed, Feb 13, 2008 at 09:15:45PM -0500, Mark Stosberg wrote:
> On Fri, 8 Feb 2008, David Roundy wrote:
> 
> > On Thu, Feb 07, 2008 at 08:46:21PM -0500, Mark Stosberg wrote:
> >> Thu Feb  7 20:44:40 EST 2008  Mark Stosberg <mark at summersault.com>
> >>   * copy over updated "shell_harness" to bugs.
> >>       Besides giving more consistent results, this is necessary for me to
> >>       be able to run the "broken-pipe.sh" test from a directory with a space in it.
> >
> > I'm not clear as to why this change is needed.  It looks like you're
> > causing the bug shell test to fail, which is precisely the opposite of what
> > it's intended to do.  Perhaps you could figure out which of these changes
> > are actually wanted?
> 
> David,
> 
> I'm sure we want the harnesses to be exactly the same. For example, the
> regular tests can now be run from within a directory with a space in,
> which we want, and we want scripts in the "bugs" directory work the same
> way. Otherwise, cases like the one I ran into, where a test in the
> "bugs" directory fails, but not for the reason the tester intended, but
> because essentially the infrastructure is buggy.
> 
> I can think of *no* benefits of having the bugs harness be different
> than the normal test harness. the bugs harness started out life being
> copied over from the tests/ directory, and I was just trying to keep it
> up to date.

I agree that there shouldn't be functional differences, but the bugs
harness started out by being copied over from tests/ and modified, and
removing those modifications effectively eliminates the reason for the
existence of the bugs/ directory.

> Of course I want tests in bugs/ to fail, but I want them to fail because
> there are bugs in the test, not in the harness.

Agreed, but we need to ignore those failures, which currently is done in
the harness.  If you remove that feature from the harness, then it needs to
be added somewhere else.
-- 
David Roundy
Department of Physics
Oregon State University


More information about the darcs-devel mailing list