[darcs-devel] [issue1093] overlong patch name warning

Trent Buck bugs at darcs.net
Tue Sep 23 03:00:42 UTC 2008


New submission from Trent Buck <trentbuck at gmail.com>:

It's bad practice (I believe) to have really long patch names.  Let
"long" be "more than seventy characters".  It would be useful if darcs
reminded users when they were naughty in this respect.

Here's a mockup.  Note that it tells users about the Right Way,
i.e. --edit.

    $ darcs rec -am 'Disable friendly fire by default.'

No change here, because the name is ≤70 characters.

    $ darcs rec -a
    What is the patch name? [user types long string here]

    Warning: patch names should be concise, but the supplied name is
    very long.  Use --edit-description if you need to add additional
    commentary.

    Change patch name? [Y/n/q]

The user can choose N to override this warning, Y to go back to the
patch name step, or q to abort the entire record operation.

    $ darcs rec -am "Long example `seq 99`."
    Warning: patch names should be concise, but the supplied name is
    very long.  Use --edit-description if you need to add additional
    commentary.  Continuing anyway.

Because used in "non-interactively", this just prints a warning and
continues on anyway.

----------
messages: 6090
nosy: dagit, kowey, simon, twb
status: unread
title: overlong patch name warning

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/issue1093>
__________________________________


More information about the darcs-devel mailing list