[darcs-devel] [issue1307] ./configure --disable-unit needs to make UNIT_FILES= # empty list

[Trent Buck]

New submission from Trent Buck <trentbuck at gmail.com>:

lelit> uhm, but it does not work: configure works, but one of the first recipes in the makefile tries to extract build deps:
lelit> src/Darcs/Patch/Test.hs:45:7:
lelit>     Could not find module `Test.QuickCheck':
lelit>       it is a member of package QuickCheck-1.1.0.0, which is hidden
lelit> make: *** [.depend] Error 1
[...]
twb> But make .depend should not need QuickCheck, that's definitely a bug.
twb> mornfall: this line is wrong:
twb> .depend:	autoconf.mk $(DARCS_FILES) $(UNIT_FILES)
lelit> the makefile should take care of not inspecting that file, when --disable-unit is given to configure
twb> mornfall: it needs to only include $UNIT_FILES *if* --disable-unit wasn't used
lelit> yeah
mornfall> twb: Have I screwed it up? I think I only resolved the conflict in favour of your version, when I was mucking with anything autoconfy.
lelit> compilation is going on now, thanks
twb> mornfall: it's my fault for introducing the dependency
twb> mornfall: but whoever added --disable-unit didn't finish the job
twb> mornfall: I'm looking at configure.ac and I don't see which variable is set by --disable-unit
twb> mornfall: it might be $(unit)

----------
messages: 7024
nosy: dmitry.kurochkin, kowey, simon, thorkilnaur, twb
status: unread
title: ./configure --disable-unit needs to make UNIT_FILES= # empty list

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/issue1307>
__________________________________