[darcs-devel] [patch236] In replacePristine, cope also with Trees... (and 2 more)

[Petr Ročkai]

New submission from Petr Ročkai <me at mornfall.net>:

Hi,

this resolves the immediate problem reported as issue1837. A regression test
would be welcome but I don't have time to work on that. The first two patches
are required, and can be reasonably cherry-picked for branch-2.4 as well.

There are caveats though...

<mornfall> kowey: (I have fixed the --partial bug, *but* the whole way it works
         is pretty dangerous...)
<mornfall> kowey: I.e. if *something* writes into the working copy while the
         get is running, it will corrupt pristine, hashed or not (since *this*
         variant of get will work in working and then copy the result over to
         pristine, instead of the other way around)
<mornfall> Most get variants work the other way around (pristine first), which
         is safe.
<mornfall> (Bloody mess.)

Yours,
   Petr.

3 patches for repository darcs-unstable at darcs.net:darcs:

Thu May  6 17:15:24 CEST 2010  Petr Rockai <me at mornfall.net>
  * In replacePristine, cope also with Trees that have no hashes in them.

Thu May  6 17:19:43 CEST 2010  Petr Rockai <me at mornfall.net>
  * Resolve issue1837: Add readWorking and use it in pristineFromWorking.

Thu May  6 17:20:35 CEST 2010  Petr Rockai <me at mornfall.net>
  * Also use readWorking in setScriptsExecutable (minor refactor).

----------
files: in-replacepristine_-cope-also-with-trees-that-have-no-hashes-in-them_.dpatch, unnamed
messages: 10989
nosy: darcs-users, mornfall
status: needs-review
title: In replacePristine, cope also with Trees... (and 2 more)

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch236>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: in-replacepristine_-cope-also-with-trees-that-have-no-hashes-in-them_.dpatch
Type: text/x-darcs-patch
Size: 52073 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20100506/1f4dff5d/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unnamed
Type: application/octet-stream
Size: 5 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20100506/1f4dff5d/attachment-0001.obj>