[darcs-devel] [patch567] resolve issue1648: darcs now uses tty instead of stdin in darcs apply --interactive
Ganesh Sittampalam
bugs at darcs.net
Fri Apr 1 13:45:14 UTC 2011
Ganesh Sittampalam <ganesh at earth.li> added the comment:
I'm a bit concerned that this leads to inconsistent behaviour between
different darcs commands, leading to potential user surprise.
The main alternative would be to introduce a flag - this probably needs
a bit of discussion on the mailing list to confirm that it's worth
complicating the UI. There's a standard template on the wiki for
"opposing" such features to make sure that they are really needed:
http://wiki.darcs.net/Ideas#proposal-gauntlet - if you're happy with the
idea of introducing a flag, would you mind starting that discussion?
Sorry to keep pushing back on your first patch!
I also have a few technical comments on the patch:
- There's a stray putStrLn "TermConfig"
- There's a new warning in Darcs.Util caused by the TermConfig case not
being covered. I guess this could lead to an actual runtime error so
should definitely be fixed.
----------
assignedto: ganesh -> bsrkaditya
status: needs-review -> followup-requested
__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch567>
__________________________________
More information about the darcs-devel
mailing list