[darcs-devel] [patch661] Allow to amend-record patch by removing some hunks

Eric Kow kowey at darcs.net
Mon Aug 15 15:45:14 UTC 2011


Hi Johannes,

Just dashing off a quick reply,

On Sun, Aug 14, 2011 at 16:26:37 +0000, Johannes Weiß wrote:
> if have now implemented an easy version. Could you please have a look at 
> it and point out to me what to improve.

Hey! Working at the Hackathon was fun.

Overall, the patch looks good although I'd be more comfortable perhaps
if another hacker could look at the prims we pass through. 

I'm not sure I understand the changes to the type of addChangesToPatch.
Is that just a cleanup or is it actually important?

Superficial stuff: thanks for fixing that typo! Normally we like these
in separate patches, but it's no big deal :-)

Hope to see you at another hackathon, or even a Darcs sprint!

-- 
Eric Kow <http://erickow.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20110815/701393d6/attachment.asc>


More information about the darcs-devel mailing list