[darcs-devel] [patch639] Correct charset in darcs send

Gabriel Kerneis bugs at darcs.net
Mon Aug 29 15:44:36 UTC 2011


Gabriel Kerneis <kerneis at pps.jussieu.fr> added the comment:

Hi,

here is the latest (and hopefully the last) version of my patch to fix
charset in darcs send.

It adds a --charset option to let the user specify any charset.
Additionnally, it tries to guess ASCII (easy) and UTF-8 (and bit harder)
charsets.  It also checks locale in case of UTF-8 to make sure there is
no discrepency, and asks before making bold assumptions.

I have tested it and it works for me but making unit tests seems a bit
hard (you would have to intercept the mail somehow and check headers).

Note that this is a fresh set of patches, the previous ones should be
discarded.

Best,
Gabriel

4 patches for repository http://darcs.net/screened:

Mon Aug 29 16:48:18 CEST 2011  Gabriel Kerneis <kerneis at pps.jussieu.fr>
  * Utility functions to check locale encoding

Mon Aug 29 16:50:46 CEST 2011  Gabriel Kerneis <kerneis at pps.jussieu.fr>
  * Add ByteStringUtils.isAscii

Mon Aug 29 17:09:29 CEST 2011  Gabriel Kerneis <kerneis at pps.jussieu.fr>
  * Add a --charset flag for darcs send

Mon Aug 29 17:16:04 CEST 2011  Gabriel Kerneis <kerneis at pps.jussieu.fr>
  * Guess ascii and utf-8 charsets
  
  In case we cannot guess the charset, or when it is utf-8 but the locale
  differs, ask the user before sending.

----------
title: Utf-8 encoding for darcs send (reloaded) -> Correct charset in darcs send

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch639>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unnamed
Type: text/x-darcs-patch
Size: 17567 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20110829/e3340412/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: utility-functions-to-check-locale-encoding.dpatch
Type: application/x-darcs-patch
Size: 183614 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20110829/e3340412/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unnamed
Type: application/octet-stream
Size: 5 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20110829/e3340412/attachment-0001.obj>


More information about the darcs-devel mailing list