[darcs-devel] [patch635] Generalise the Apply class by introducing an ApplyStat...
Petr Ročkai
bugs at darcs.net
Mon Jul 11 19:55:08 UTC 2011
Petr RoÄkai <me at mornfall.net> added the comment:
As the last patch says, we have all tests passing now on the V3
front. Methodology therefore demands we need to write more tests, including
some that'll fail, so we can improve the code accordingly.
Yours,
Petr
PS: I think this could be screened now. Another quick glance from someone else
would be appreciated first, though.
7 patches for repository http://darcs.net:
Tue Jul 5 10:42:35 CEST 2011 Petr Rockai <me at mornfall.net>
* Parametrise part of Patch.V2 tests over the Prim to use.
Tue Jul 5 10:43:58 CEST 2011 Petr Rockai <me at mornfall.net>
* Enable tests for V3 prims and V2 patches with V3 prims (all fail).
Sat Jul 9 11:10:38 CEST 2011 Petr Rockai <me at mornfall.net>
* Generalise the Apply class by introducing an ApplyState associated type.
The ApplyState type corresponds to the object that the patches manipulate. For
traditional (V1) Prims, this is a Tree, representing a filesystem tree. For V3
Prims, this will likely be an uuid -> object map, or a variation thereof.
In an ideal world, apply would be :: patch -> ApplyState patch -> ApplyState
patch, but for efficiency reasons, we want to evaluate patch application in a
monad, and also embed unevaluated monadic computations within the state object
itself. Therefore, (ApplyState patch) is :: (* -> *) -> *, the parameter being
a monad, like what Tree expects. In normal Darcs, this will be IO, but most
operations are expected to be monad-independent. We use Maybe in the testsuite.
Sat Jul 9 11:44:11 CEST 2011 Petr Rockai <me at mornfall.net>
* Lift localIdentity into PrimClassify (as anIdentity).
Sat Jul 9 11:59:39 CEST 2011 Petr Rockai <me at mornfall.net>
* Start filling in gaps in the V3 prims.
Sat Jul 9 19:51:57 CEST 2011 Petr Rockai <me at mornfall.net>
* Fill in more blanks in V3 Prim implementation.
With the current test coverage (generic Prim tests), we are only missing
read/write to pass everything. Of course, we want to eventually improve test
coverage, which should lead to further exposed gaps.
Mon Jul 11 21:39:51 CEST 2011 Petr Rockai <me at mornfall.net>
* Implement rudimentary Show/Read instances for V3 prims. All tests pass now.
__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch635>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unnamed
Type: text/x-darcs-patch
Size: 179921 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20110711/cb86225b/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: parametrise-part-of-patch_v2-tests-over-the-prim-to-use_.dpatch
Type: application/x-darcs-patch
Size: 223611 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20110711/cb86225b/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unnamed
Type: application/octet-stream
Size: 5 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20110711/cb86225b/attachment-0001.obj>
More information about the darcs-devel
mailing list