[darcs-devel] darcs style

[Eric Kow]

Thanks Will,

Janitorial patches are great.  I waver between doing them myself (out of irritation) and trying to hold off so that somebody else can work on them (and hopefully get the bug!)

I think this document could help.  It comes from our last “gah! we should really improve the style” discussion.  Could help us to avoid going over old ground.

http://wiki.darcs.net/Development/CodingStyle

Please don't hesitate to run with, challenge, modify that document!

Thanks,

On 23 Jan 2012, at 12:44, Iago Abal wrote:

> 
> On Mon, Jan 23, 2012 at 4:12 AM, Will Langstroth <will at langstroth.com> wrote:
> Hi all,
> 
> Wondering if you're accepting "janitorial" patches. If you've seen Johan Tibell's Haskell Style Guide, and it seems reasonable, I'd be happy to have a go at making darcs stick to that one style (or one comparable) for easier reading. I'm just getting into the code, and the existing style is eclectic enough to be distracting.
> Your intentions are good, but I don't think Darcs is going to stick to a particular coding style. Most likely you will make an effort but Darcs developers will continue coding in their particular style, so (ideally) you will end submitting patches regularly fixing the coding style.
> 
> In base of my previous experience you are going to fail convincing Darcs people to follow a concrete coding style. But lets try, perhaps you will succeed -- good luck!
> 
> By the way, if you can add comments to code you have difficulty to understand that would be great.
> 
> Not sure where that fits in the bug tracker workflow, either - since these types of changes are strictly formatting, would an email patch be sufficient?

-- 
Eric Kow <http://erickow.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20120123/409e9644/attachment.asc>