[darcs-devel] [issue2213] last regrets doesn't respect dependencies when going back

[Owen Stephens]

New submission from Owen Stephens <darcs at owenstephens.co.uk>:

1. Summarise the issue (what were doing, what went wrong?)

lastregrets allows you to "go back" through a list of patches.
Unfortunately, it doesn't respect dependencies (in its presentation to a
user):
$ darcs init --repo R
$ darcs init --repo S
$ cd R
 
$ echo 'a' > file
$ darcs rec -alm a
 
$ echo 'b' > file
$ darcs rec -alm b

$ darcs push ../S
Sat Jul 21 16:27:05 BST 2012  Owen Stephens <darcs at owenstephens.co.uk>
  * a
Shall I push this patch? (1/2)  [ynW...], or ? for more options: n
Will not ask whether to push 1 already decided patch.
Do you want to push these patches? [Yglqk...], or ? for more options: k
Sat Jul 21 16:27:05 BST 2012  Owen Stephens <darcs at owenstephens.co.uk>
  * b
Shall I push this patch? (2/2)  [yNw...], or ? for more options: y
Do you want to push these patches? [Yglqk...], or ? for more options: l
---- Already selected patches ----
Sat Jul 21 16:27:05 BST 2012  Owen Stephens <darcs at owenstephens.co.uk>
  * a
Sat Jul 21 16:27:05 BST 2012  Owen Stephens <darcs at owenstephens.co.uk>
  * b
---- end of already selected patches ----

So darcs adds the depended-on patch to the list of selected patches, but
it asks about b before asking about a - which it didn't do, on first
asking (due to skipping dependencies of a).

2. What behaviour were you expecting instead?

Pressing k above should go straight to a, rather than via b.

3. What darcs version are you using? (Try: darcs --exact-version)

2.9.1 HEAD

4. What operating system are you running?

Ubuntu x86_64

----------
messages: 15909
nosy: owst
status: unknown
title: last regrets doesn't respect dependencies when going back

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/issue2213>
__________________________________