[darcs-devel] [patch1057] correctly set curl connection timeout

Guillaume Hoffmann bugs at darcs.net
Thu Feb 21 23:49:01 UTC 2013


New submission from Guillaume Hoffmann <guillaumh at gmail.com>:

This patch makes that DARCS_CONNECTION_TIMEOUT is taken into account.
Noticeably, in cases like the following (non-responding server):

    export DARCS_CONNECTION_TIMEOUT=1 && darcs changes --repo=http://10.1.2.3/

Also, it seems that the correct parameter to pass to libcurl is
CURLOPT_CONNECTTIMEOUT, which limit the connection time to a server.
CURLOPT_TIMEOUT (used up to now) is a timeout on any connection:
for instance transferring a big patch can be interrupted by such limit.

So this patch uses CURLOPT_CONNECTTIMEOUT instead of CURLOPT_TIMEOUT.

1 patch for repository http://darcs.net:

Fri Feb 22 00:43:25 CET 2013  Guillaume Hoffmann <guillaumh at gmail.com>
  * correctly set curl connection timeout

----------
files: correctly-set-curl-connection-timeout.dpatch, patch-preview.txt, unnamed
messages: 16717
nosy: gh
status: needs-screening
title: correctly set curl connection timeout

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1057>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 851 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20130221/a295a7c9/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: correctly-set-curl-connection-timeout.dpatch
Type: application/x-darcs-patch
Size: 15949 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20130221/a295a7c9/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unnamed
Type: application/octet-stream
Size: 5 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20130221/a295a7c9/attachment.obj>


More information about the darcs-devel mailing list