[darcs-devel] [patch1131] Resolve Issue1416: put log files in tempdir instead of...

[Guillaume Hoffmann]

Guillaume Hoffmann <guillaumh at gmail.com> added the comment:

Nice. It seems to work well for record, amend, tag (without or with
--logfile and --delete-logfile).

However with send, when given "--logfile" it does not seem to clean
_darcs/darcs-send.final  . Moreover when passed "--delete-log-file", it
does not delete the given log file.

To enhance the implementation for send (when no logfile is given), you
can delete darcs-send right after copying it to .final (currently you're
doing it not at the very end). In fact you could just rename the file to
.final (and then read its contents with readDocBinFile).

About the patch itself, please send an amended version without unrelated
hunks, lines or characters:

* hunk ./src/Darcs/UI/Commands/Record.hs 20
* hunk ./src/Darcs/UI/Commands/Record.hs 407 (last line with trailing
spaces)
* hunk ./src/Darcs/UI/Commands/Record.hs 530
* hunk ./src/Darcs/Util/Global.hs 177 (trailing whitespace)

In the patch long description: temporal -> temporary.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1131>
__________________________________