[darcs-devel] [patch1134] resolve issue1987: Garbage collection for inventories ...

[Owen Stephens]

Owen Stephens <darcs at owenstephens.co.uk> added the comment:

Nice patch! A few comments:

I think there is a large amount of duplication between
cleanPatches/cleanInventories - can you abstract over the differences
and reduce duplication?

Why do you convert the [FilePath] to [ByteString] before converting to a
set, only to convert back after you've taken the intersection?

I think using a white list of files rather than okayHash would make the
intent more obvious.

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1134>
__________________________________