[darcs-devel] [issue2410] --look-for-replaces does not work in real world cases

[Ben Franksen]

New submission from Ben Franksen <benjamin.franksen at helmholtz-berlin.de>:

1. Summarise the issue (what were doing, what went wrong?)

darcs whatsnew --look-for-replaces does not detect any replaces in
real-world cases. For instance try (in the current screened repo)

sed -ri 's/\bopts\b/flags/g' src/Darcs/UI/RemoteApply.hs

and then

darcs whatsnew --look-for-adds

What you get is:

hunk ./src/Darcs/UI/RemoteApply.hs 21
-remoteApply opts repodir bundle
-    = case applyAs opts of
+remoteApply flags repodir bundle
+    = case applyAs flags of
hunk ./src/Darcs/UI/RemoteApply.hs 24
-            | isSshUrl repodir -> applyViaSsh opts (splitSshUrl
repodir) bundle
-            | isHttpUrl repodir -> applyViaUrl opts repodir bundle
-            | otherwise -> applyViaLocal opts repodir bundle
+            | isSshUrl repodir -> applyViaSsh flags (splitSshUrl
repodir) bundle
+            | isHttpUrl repodir -> applyViaUrl flags repodir bundle
+            | otherwise -> applyViaLocal flags repodir bundle
hunk ./src/Darcs/UI/RemoteApply.hs 28
-                   then applyViaSshAndSudo opts (splitSshUrl repodir)
un bundle
+                   then applyViaSshAndSudo flags (splitSshUrl repodir)
un bundle
hunk ./src/Darcs/UI/RemoteApply.hs 40
-applyViaLocal opts repo bundle =
+applyViaLocal flags repo bundle =
hunk ./src/Darcs/UI/RemoteApply.hs 42
-    pipeDoc darcs ("apply":"--all":"--repodir":repo:applyopts opts) bundle
+    pipeDoc darcs ("apply":"--all":"--repodir":repo:applyopts flags) bundle
hunk ./src/Darcs/UI/RemoteApply.hs 45
-applyViaUrl opts repo bundle =
+applyViaUrl flags repo bundle =
hunk ./src/Darcs/UI/RemoteApply.hs 48
-         Nothing -> applyViaLocal opts repo bundle
+         Nothing -> applyViaLocal flags repo bundle
hunk ./src/Darcs/UI/RemoteApply.hs 54
-applyViaSsh opts repo =
-    pipeDocSSH repo [Ssh.remoteDarcs (remoteDarcs opts) ++" apply --all
"++unwords (applyopts opts)++
+applyViaSsh flags repo =
+    pipeDocSSH repo [Ssh.remoteDarcs (remoteDarcs flags) ++" apply
--all "++unwords (applyopts opts)++
hunk ./src/Darcs/UI/RemoteApply.hs 59
-applyViaSshAndSudo opts repo username =
-    pipeDocSSH repo ["sudo -u "++username++" "++Ssh.remoteDarcs
(remoteDarcs opts)++
+applyViaSshAndSudo flags repo username =
+    pipeDocSSH repo ["sudo -u "++username++" "++Ssh.remoteDarcs
(remoteDarcs flags)++
hunk ./src/Darcs/UI/RemoteApply.hs 64
-applyopts opts = ["--debug" | Debug `elem` opts]
+applyopts flags = ["--debug" | Debug `elem` opts]

2. What behaviour were you expecting instead?

A single line

replace ./src/Darcs/UI/RemoteApply.hs [A-Za-z_0-9] opts flags

3. What darcs version are you using? (Try: darcs --exact-version)

2.9.9 (+ 164 patches)

----------
messages: 17757
nosy: bf
status: unknown
title: --look-for-replaces does not work in real world cases

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/issue2410>
__________________________________