[darcs-devel] [patch1201] clarify naming of applyPatches functions (and 2 more)

[Ganesh Sittampalam]

New submission from Ganesh Sittampalam <ganesh at earth.li>:

A few code simplifications and a bugfix.

3 patches for repository darcs-unstable at darcs.net:screened:

Tue Oct 21 15:06:58 BST 2014  Ganesh Sittampalam <ganesh at earth.li>
  * clarify naming of applyPatches functions

Tue Oct 21 17:08:25 BST 2014  Ganesh Sittampalam <ganesh at earth.li>
  * Share applyPatches code between pull and apply
  
  Abstract the applyPatches function from the apply command, and make pull
  use it.
  
  This means the following changes to apply:
  
   - The outcome is now displayed using 'putInfo', which means it will
     respect options like '-q' where it didn't before. This seems reasonable.
  
  It means the following changes to pull:
  
   - We now call 'setEnvDarcsPatches'. This seems reasonable.
  
   - We now call 'withSignalsBlocked' when applying patches. I think this is
     harmless or an improvement.
  
   - The output messages are a bit more generic, but I don't think any important
     detail is lost.
  
   - We now call 'redirectOutput' around the messages. --reply isn't passed
     to pull so this should make no difference.
  

Tue Oct 21 19:24:11 BST 2014  Ganesh Sittampalam <ganesh at earth.li>
  * resolve issue2403: need to avoid moving the rebase patch to the end
  
  This bug is a pretty good example of why the "rebase internal patch" is a rather
  nasty hack - see 'Note [Rebase representation]' in src/Darcs/Patch/Rebase.hs

----------
files: clarify-naming-of-applypatches-functions.dpatch, patch-preview.txt, unnamed
messages: 17712
nosy: ganesh
status: needs-screening
title: clarify naming of applyPatches functions (and 2 more)

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1201>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 29891 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20141022/37ba25b4/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clarify-naming-of-applypatches-functions.dpatch
Type: application/x-darcs-patch
Size: 55163 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20141022/37ba25b4/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unnamed
Type: application/octet-stream
Size: 5 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20141022/37ba25b4/attachment-0001.obj>