[darcs-devel] [patch1267] changed the argument order of PatchSet and backward op...

Ganesh Sittampalam bugs at darcs.net
Tue Feb 10 18:57:12 UTC 2015


Ganesh Sittampalam <ganesh at earth.li> added the comment:

I have no objection to the idea.

I'm not entirely sure if it's better or not, but I certainly get confused by the 
ordering of these "reverse" operators as they stand, so even if I still get 
confused I don't think I'll have lost anything :-)

Reordering :<: should be pretty safe as both the witnesses and the patch type 
themselves will be changed. I'm mildly concerned that we could miss places where 
+<+ needs to change because there are places in the code where we do unsafe 
things with the witnesses, but I think with the backup of the tests the risk 
should be fairly low.

----------
nosy: +ganesh

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1267>
__________________________________


More information about the darcs-devel mailing list