[darcs-devel] [patch1298] in annotate command, push call to withRe... (and 2 more)

[Guillaume Hoffmann]

New submission from Guillaume Hoffmann <guillaumh at gmail.com>:

I went with the proposal #2 of http://bugs.darcs.net/issue2438.
That is, patch index is only created:

* when running annotate on a file or dir
* when running non-interactive log on a file
* for the above two cases, only if repository
  lock can be taken, otherwise PI creation is
  not attempted
* on init, clone, convert with --patch-index

This makes patch index creation happen only when the user runs
a command that uses it. In the future, if we change our mind
(for instance if we find a way to accelerate PI building)
we may come back to the previous default behaviour without
much hassle.

I'll wait until tomorrow to screen this bundle, in case
there is something very wrong with it.

3 patches for repository http://darcs.net:

patch a3465a6ac8ed406bf40c2f477fca7fcbf4305f9b
Author: Guillaume Hoffmann <guillaumh at gmail.com>
Date:   Wed Feb 25 11:39:30 ART 2015
  * in annotate command, push call to withRepository deeper

patch 324bbe2cc34e68e3d83b142dbfe4c4831a0b1de1
Author: Guillaume Hoffmann <guillaumh at gmail.com>
Date:   Wed Feb 25 15:01:15 ART 2015
  * resolve issue2438: no longer build patch index by default on cloning
  * build automatically only with annotate or non-interactive `log file`
  * patch index creation only occurs if the lock can be taken
  * PI creation only happens on init, clone and convert if
    --enable-patch-index is passed, disabled by default
  * PI creation no longer done when finalizing a repo job
  * the only way to have the file `_darcs/no_patch_index` created,
    is to run `optimize disable-patch-index`, or to ctrl-c
    PI creation (during annotate, log, init, clone or convert)

patch 56466a3b4ccae2959aef39e65ac02ba60afeace5
Author: Guillaume Hoffmann <guillaumh at gmail.com>
Date:   Wed Feb 25 15:02:23 ART 2015
  * fix patch-index tests after defaults change

----------
files: in-annotate-command_-push-call-to-withrepository-deeper.dpatch, patch-preview.txt, unnamed
messages: 18223
nosy: gh
status: needs-screening
title: in annotate command, push call to withRe... (and 2 more)

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1298>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 26381 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20150225/f91bbc33/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: in-annotate-command_-push-call-to-withrepository-deeper.dpatch
Type: application/x-darcs-patch
Size: 42615 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20150225/f91bbc33/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unnamed
Type: application/octet-stream
Size: 5 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20150225/f91bbc33/attachment-0001.obj>