[darcs-devel] [patch1373] resolve issue2400

[Ganesh Sittampalam]

On 28/06/2015 20:51, Ben Franksen wrote:
> 
> Ben Franksen <benjamin.franksen at helmholtz-berlin.de> added the comment:
> 
> One patch following up and improving on the one one that claims to have
> resolved issue2400. The other patch is a dependency (see patch1380). I
> think it makes a lot of sense to apply them all together anyway, also for
> 2.10.1, so no need to rebase patch1380, which is why I have obsoleted the
> latter.
> 
> 2 patches for repository http://darcs.net/screened:
> 
> patch 90657a5991d2c040255c9a31c02e50122df630f5
> Author: Ben Franksen <benjamin.franksen at helmholtz-berlin.de>
> Date:   Thu Jun 25 00:15:07 CEST 2015
>   * resolve issue2459: fall back to writing the file if createLink fails
> 
> patch 23bad6777ea545cbf8f5d2856ab3a50d190b0f8d
> Author: Ben Franksen <benjamin.franksen at helmholtz-berlin.de>
> Date:   Sun Jun 28 20:18:58 CEST 2015
>   * remove race from D.R.Packs, further simplify the code
>   
>   It turned out cancelling the other thread makes the error only less
>   probable, I could still reproduce it. The reason is that the race is
>   semantically incorrect: The extra patches to fetch are not a subset of the
>   ones we get from the pack, since they may contain patches that were added
>   after creation of the pack.
>   
>   In order to further simplify the code and remove possible race conditions,
>   the meta-filelist-xxx files are not written to disk. Instead we directly
>   evaluate their content and pass it to fetchFilesUsingCache.

Now I've got onto looking at this patch, I see my comments on the
previous patch may be a bit obsolete as things have moved on a bit and
now all the actions are all run to completion, now in parallel whereas
in the original code before your changes it was (I think) in serial.

One question about the followup is that now it doesn't specifically know
about the "meta-filelist-inventories" and "meta-filelist-pristine"
names. Does this matter?

I'm still rather confused by the whole module in general, I'll keep
trying to understand the intentions...

Cheers,

Ganesh