[darcs-devel] [patch1332] Generalize Darcs.UI.Commands.Dist.doFastZip

Dan Frumin bugs at darcs.net
Sun Jun 7 18:43:21 UTC 2015


Dan Frumin <difrumin at gmail.com> added the comment:

I think I might have figured it out. Here is an updated patch. It also
fixes another mistake in the previous patch: the message ("Created ...zip")
was erroneously omitted.


On Sat, May 30, 2015 at 3:13 PM, Ganesh Sittampalam <bugs at darcs.net> wrote:

>
> Ganesh Sittampalam <ganesh at earth.li> added the comment:
>
> This is where it goes wrong - note that it's conditional on 'unzip' being
> present:
>
>     | # Only do following if unzip is present
>     | unzip >& /dev/null &&
>     | (
>     | unzip temp1.zip
>     | diff -r temp_orig temp1
>     | rm -rf temp1
>     | )
>     | + unzip
>     | + unzip temp1.zip
>     | :  mismatching "local" filename (file-4),
>     |          continuing with "central" filename version
>     | mapname:  conversion of  failed
>
> I'm running NixOS (commit 37e2733) and I've got this:
>
>     $ unzip -v
>     UnZip 6.00 of 20 April 2009, by Info-ZIP.
>
> I suspect it's because we're now creating paths starting "./foo" where
> they were previously "foo".
>
> __________________________________
> Darcs bug tracker <bugs at darcs.net>
> <http://bugs.darcs.net/patch1332>
> __________________________________
>

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1332>
__________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20150607/7403de4b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: generalize-darcs_ui_commands_dist_dofastzip.dpatch
Type: application/octet-stream
Size: 2633 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20150607/7403de4b/attachment.obj>


More information about the darcs-devel mailing list