[darcs-devel] [patch1375] removed special handling of --to-match from cloneRepos...

[Ben Franksen]

New submission from Ben Franksen <benjamin.franksen at helmholtz-berlin.de>:

I guess the code I deleted here is cruft left over from adding the "packs"
feature. This should be carefully reviewed and tested a bit more to see if
there are unwanted side effects. (I don't expect any, just being careful.)

TODO: Verify that the special handling this patch removes is not faster when
using 'darcs clone --to-match' with a remote repo that has not been
optimized to provide packs (using darcs optimize http).

1 patch for repository http://darcs.net/screened:

patch f9c60286ae4e03f4fbab473ced211eec370a1ce0
Author: Ben Franksen <benjamin.franksen at helmholtz-berlin.de>
Date:   Mon Jun 22 00:04:21 CEST 2015
  * removed special handling of --to-match from cloneRepository
  
  I made lots of tests and found
  (a) no difference in the resulting repos
  (b) the method chosen with toMatch=False is always much faster, (more than
      twice as fast, in fact) regardless of whether the repo is local or
      remote
  (c) --to-patch was not handled when passing the toMatch parameter, causing
      the slower variant to be chosen /only/ for --to-match

----------
files: patch-preview.txt, removed-special-handling-of-__to_match-from-clonerepository.dpatch, unnamed
messages: 18591
nosy: bf
status: needs-screening
title: removed special handling of --to-match from cloneRepos...

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1375>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 1665 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20150622/98346cb2/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: removed-special-handling-of-__to_match-from-clonerepository.dpatch
Type: application/x-darcs-patch
Size: 29118 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20150622/98346cb2/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: unnamed
Type: application/octet-stream
Size: 5 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20150622/98346cb2/attachment-0001.obj>