[darcs-devel] [patch1366] added a test to show that show files is ... (and 6 more)

Guillaume Hoffmann bugs at darcs.net
Mon Jun 22 21:19:20 UTC 2015


Guillaume Hoffmann <guillaumh at gmail.com> added the comment:

The three test patches could be just a single one, with a single test
script instead of two.  And the renaming of that shell test should occur
in the patch that fix the bug. I think it's cleaner like that.

The tests scripts are OK anyway.

About the "expandTo must unconditionally expand tree along the given
path", could this cause some performance issue? For instance, with
commands like whatsnew or record?

The change to ShowContents are good (function is much easier to follow now).

Accepting it (also into 2.10).

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1366>
__________________________________


More information about the darcs-devel mailing list