[darcs-devel] [patch1406] refactor breakAfterNthNewline and breakBeforeNthNewline

Guillaume Hoffmann bugs at darcs.net
Sat Nov 7 18:48:31 UTC 2015


Guillaume Hoffmann <guillaumh at gmail.com> added the comment:

Yes you're right.

I believe the whole applyHunks/applyHunkLines business in
Darcs.Patch.Prim.Apply (the only places that call
break{After,Before}NthNewline) should be documented, commented, and
probably refactored. breakAfterNthNewline and breakBeforeNthNewline may
end up moved to that module too.

For now, I wanted to tackle a low hanging fruit that weighted on the
memory consumption of "darcs diff". I'm opening a ticket for refactoring
Darcs.Patch.Prim.Apply .

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1406>
__________________________________


More information about the darcs-devel mailing list