[darcs-devel] [patch1373] refactored Darcs.Repository (and 1 more)

[Guillaume Hoffmann]

Guillaume Hoffmann <guillaumh at gmail.com> added the comment:

I changed a few comments and added a few debug messages
so that it's possible to see what happens when cloning with
packs.

You can test from the following repositories:

-- this one has up to date packs in the current new order
-- (older to newer)
http://www.cs.famaf.unc.edu.ar/~hoffmann/darcs.net2/ 

-- this one has outdated packs (1 patch is missing) in the
-- old order  (newer to older)
http://www.cs.famaf.unc.edu.ar/~hoffmann/darcs.net2/ 

For instance:

    $ darcs clone http://www.cs.famaf.unc.edu.ar/~hoffmann/darcs.net2/  --verbose --packs  --debug 2>&1  |less

And then grep for TAR and FILE.

Performance is good, except when reading patch packs that
are in the old order, in which case pack grabbing stops
early and individual patch download continues.

I'm screening the bundle.

4 patches for repository http://darcs.net:

patch a2a1a5b45c636915344a9d27096bddb86beec3f1
Author: Guillaume Hoffmann <guillaumh at gmail.com>
Date:   Thu Oct 22 22:01:12 ART 2015
  * comment in doOptimizeHTTP

patch 3927bb3b8454d47065bd4f2598f127171a8d1fa3
Author: Guillaume Hoffmann <guillaumh at gmail.com>
Date:   Thu Oct 22 22:21:09 ART 2015
  * ignore meta- files in packs when cloning
  Let's not try to be clever.

patch 3ed524742966fe6a86e9836d30af63dd231b07c7
Author: Guillaume Hoffmann <guillaumh at gmail.com>
Date:   Fri Oct 23 14:51:44 ART 2015
  * download patches pack asynchronously

patch 0ca671d83d1c4fd416889b5d073c9edb5bfd1e70
Author: Guillaume Hoffmann <guillaumh at gmail.com>
Date:   Fri Oct 23 15:30:20 ART 2015
  * refactor clone code
  * take lock only once for eveything that happens after
    new repository initialization
  * factorize cache and sources handling
  * no longer look for new patches when getting basic pack,
    since we only get up-to-date basic packs anyway
  * show packs exceptions on standard output so that we fix
    them by the next release
  * switch patches retrieval order when using packs
    (makes more sense to have oldest patches in pack since
    it can be outdated)

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1373>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 20571 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20151023/2f6b94f8/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: comment-in-dooptimizehttp.dpatch
Type: application/x-darcs-patch
Size: 51840 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20151023/2f6b94f8/attachment-0003.bin>
-------------- next part --------------
.