[darcs-devel] [patch1417] Rename Prim.V3 to Prim.FileUUID (and 7 more)

Guillaume Hoffmann bugs at darcs.net
Wed Jan 27 12:28:39 UTC 2016


Guillaume Hoffmann <guillaumh at gmail.com> added the comment:

I'm OK with all patches. A few comments on the following:

* patch "disentangle the state-specific ApplyMonad methods": introduces
the definition `type ApplyMonadStateOperations state :: (* -> *) ->
Constraint` used in two places: `type ApplyMonadStateOperations Tree =
ApplyMonadTree` and  `type ApplyMonadStateOperations ObjectMap =
ApplyMonadObjectMap`.  Both ApplyMonadObjectMap and ApplyMonadTree are
new classes. (ApplyMonadStateOperations state m) is now a superclass of
ApplyMonad. There is now a separation between ApplyMonad and
ApplyMonadTree (see Darcs.Patch.ApplyMonad). Seems good.

* patch "applyToTree is just a specialisation of applyToState": why do
we still need ApplyToState? It doesn't seem to be used anywhere.

----------
status: needs-review -> review-in-progress

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1417>
__________________________________


More information about the darcs-devel mailing list