[darcs-devel] [issue2503] Use of externalPackageDeps in Setup is bad

Edward Z. Yang bugs at darcs.net
Fri Jul 22 06:14:11 UTC 2016


New submission from Edward Z. Yang <ezyang at mit.edu>:

In Setup you have:

    ["module Version where"
    ,"builddeps, version, context :: String"
    ,"version = \"" ++ version ++ " (" ++ state ++ ")\""
    ,"builddeps = " ++ show ( formatdeps (externalPackageDeps lbi))
    ,"context = " ++ case ctx of
                       Just x -> show x
                       Nothing -> show "context not available"

The use of `externalPackageDeps` here is bad juju. It is the deps for ALL 
components, including the test suite. I doubt you want to build Darcs with the test 
suite dependencies in build deps.

If it's just library deps you care about here (which is probably the case), you can 
use `getComponentLocalBuildInfo` to grab the `CLibName` component, and then read 
the deps off that.

----------
messages: 19235
nosy: ezyang
status: unknown
title: Use of externalPackageDeps in Setup is bad

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/issue2503>
__________________________________


More information about the darcs-devel mailing list