[darcs-devel] [patch1517] rename Darcs.Repository.HashedRepo to Da... (and 6 more)

[Guillaume Hoffmann]

New submission from Guillaume Hoffmann <guillaumh at gmail.com>:

This is a big refactoring of a few modules that live in
Darcs.Repository.*.

In summary, the idea is to end Darcs.Repository.Internal
as it is now. The main reason is because "Internal" is
a meaningless name. The topics covered by the "Internal"
module are actually:

* repository detection/finding
* pending-related functions
* merge/conflict-related functions
* working-copy-related functions
* hashed-related (pristine, inventory) functions

This bundle aims at organizing these topics into
separate modules. It only creates one new module, Working,
while it reuses others.

The patch I am less happy with is "move hashed related
functions from Internal to Hashed", mostly because it
makes several patch index-related functions require as
an argument the PatchSet of the repository (the PatchIndex
module can no longer call the readRepo function due to
a cycle). Maybe it is cleaner in a way.
Also, it's a big patch, maybe hard to review.

Opinions?

7 patches for repository http://darcs.net:

patch 107f00060c78c4cf5faacfe4d218f1f3e3b4db9b
Author: Guillaume Hoffmann <guillaumh at gmail.com>
Date:   Mon Sep 26 12:41:45 ART 2016
  * rename Darcs.Repository.HashedRepo to Darcs.Repository.Hashed

patch c903942b2d3e563e7ac7099df794dcf4dc09bf38
Author: Guillaume Hoffmann <guillaumh at gmail.com>
Date:   Mon Sep 26 15:29:08 ART 2016
  * move pending related functions from Internal to Pending

patch 8aaf8ab696e077e6d1a01800c99c6d400a3b75b8
Author: Guillaume Hoffmann <guillaumh at gmail.com>
Date:   Mon Sep 26 15:33:20 ART 2016
  * move merge related functions from Internal to Merge

patch 2e686da6e6bfad2ab1ee2becc8d5bb3fe87df3e1
Author: Guillaume Hoffmann <guillaumh at gmail.com>
Date:   Mon Sep 26 17:11:37 ART 2016
  * create Repository.Working

patch c80b331bcf3448801abee6a209bd61fc65797348
Author: Guillaume Hoffmann <guillaumh at gmail.com>
Date:   Mon Sep 26 17:17:13 ART 2016
  * move repoPatchType from Internal to InternalTypes

patch 38c35025a4810d5332d108ab910d2933ca4d3387
Author: Guillaume Hoffmann <guillaumh at gmail.com>
Date:   Tue Sep 27 12:46:18 ART 2016
  * move hashed related functions from Internal to Hashed

patch b32f3044a946992b9e87c8436971c42081d4a3cd
Author: Guillaume Hoffmann <guillaumh at gmail.com>
Date:   Tue Sep 27 13:01:23 ART 2016
  * rename Darcs.Repository.Internal to Darcs.Repository.Identify

----------
files: patch-preview.txt, rename-darcs_repository_hashedrepo-to-darcs_repository_hashed.dpatch, unnamed
messages: 19291
nosy: gh
status: needs-screening
title: rename Darcs.Repository.HashedRepo to Da... (and 6 more)

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1517>
__________________________________
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-preview.txt
Type: text/x-darcs-patch
Size: 109858 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20160927/17457543/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rename-darcs_repository_hashedrepo-to-darcs_repository_hashed.dpatch
Type: application/x-darcs-patch
Size: 110568 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/darcs-devel/attachments/20160927/17457543/attachment-0003.bin>
-------------- next part --------------
.