[darcs-devel] [patch1550] remove the match option hack for clone
Guillaume Hoffmann
bugs at darcs.net
Fri Aug 18 22:10:18 UTC 2017
Guillaume Hoffmann <guillaumh at gmail.com> added the comment:
Sorry for answering so late.
I have looked at the code and I'm not sure we should accept this patch.
Ben you're saying:
> Previously, for the clone command, --xxx was not supported,
> but --to-xxx was [not], and then --to-xxx was silently converted
> to --xxx.
But the help of 'clone' says:
~~~
You can also make a copy of an untagged state using the `--to-patch` or
`--to-match` options, which exclude patches *after* the first matching
patch. Because these options treat the set of patches as an ordered
sequence, you may get different results after reordering with `darcs
optimize reorder`.
~~~
It seems to me that internally, the flag conversion is a 'hack' because
of the implementation of clone uses --XXX flags even if they really mean
--to-XXX.
If we want to fix that, we should probably change that implementation so
that it actually uses the --to-XXX flags, except --to-tag which it
should reject and only accept --tag (because of
http://bugs.darcs.net/issue2199 ).
__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1550>
__________________________________
More information about the darcs-devel
mailing list