[darcs-devel] [patch1536] resolve issue2526: actually consider boring option in ...

Ganesh Sittampalam bugs at darcs.net
Mon Mar 20 05:09:46 UTC 2017


Ganesh Sittampalam <ganesh at earth.li> added the comment:

Looks good.

A minor note about adding tests when fixing bugs - it's slightly nicer 
if your first patch adds a "failing" test, then the second fixes the 
bug and renames the failing test. That way people bisecting in future 
for test breakage won't accidentally hit the intermediate state, but 
it's still easy to check that the test failed before the fix and passes 
after it.

----------
status: needs-review -> accepted

__________________________________
Darcs bug tracker <bugs at darcs.net>
<http://bugs.darcs.net/patch1536>
__________________________________


More information about the darcs-devel mailing list